Fall back to full page load if new url doesn't have root element#19
Open
scottsb wants to merge 1 commit intoestrattonbailey:masterfrom
Open
Fall back to full page load if new url doesn't have root element#19scottsb wants to merge 1 commit intoestrattonbailey:masterfrom
scottsb wants to merge 1 commit intoestrattonbailey:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally URLs that point to pages on the site without a shared root element would be labeled with the
no-ajaxclass and thus not trigger the PJAX behavior. However, sometimes this is missed, and before this PR, these links would simply fail to load (clicking would do nothing). This change allows the load to proceed as a full-page load. It's wasteful because it still triggers the XHR load in between, but at least the site does not break. (Usingno-ajaxis still the right solution to avoid this waste--this is intended only as a failsafe.)